Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile time warning in Sensors_TEST #297

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Dec 5, 2022

Signed-off-by: Aditya [email protected]

🦟 Bug fix

Summary

This PR fixes a compile time warning in Sensors_TEST.cc due to ign- > gz renaming.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #297 (404ce89) into gz-sensors7 (c455a36) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-sensors7     #297   +/-   ##
============================================
  Coverage        69.24%   69.24%           
============================================
  Files               35       35           
  Lines             3749     3749           
============================================
  Hits              2596     2596           
  Misses            1153     1153           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adityapande-1995
Copy link
Contributor Author

The failures in Jammy seem unrelated to the changes made here (failures in camera tests), merging !

@adityapande-1995 adityapande-1995 merged commit 3ab9083 into gz-sensors7 Dec 5, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/ign_to_gz_warning branch December 5, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants