Skip to content

Commit

Permalink
Remove static for maps from Factory.hh (#635)
Browse files Browse the repository at this point in the history
* Remove static for maps from Factory.hh

Signed-off-by: Shameek Ganguly <[email protected]>

* Bugfix for inline keyword in Factory.hh

Signed-off-by: Shameek Ganguly <[email protected]>

Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
  • Loading branch information
3 people authored Mar 19, 2021
1 parent 41b0ffa commit 636bad5
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions include/ignition/gazebo/components/Factory.hh
Original file line number Diff line number Diff line change
Expand Up @@ -310,13 +310,11 @@ namespace components
private: std::map<ComponentTypeId, StorageDescriptorBase *> storagesById;

/// \brief A list of IDs and their equivalent names.
/// \detail Make it non-static on version 2.0.
public: inline static std::map<ComponentTypeId, std::string> namesById;
public: std::map<ComponentTypeId, std::string> namesById;

/// \brief Keep track of the runtime names for types and warn the user if
/// they try to register different types with the same typeName.
/// \detail Make it non-static on version 2.0.
public: inline static std::map<ComponentTypeId, std::string>
public: std::map<ComponentTypeId, std::string>
runtimeNamesById;
};

Expand Down

0 comments on commit 636bad5

Please sign in to comment.