Merge pull request #828 from ignitionrobotics/3-to-4-2021-05-20

3 to 4 2021 05 20

.github/workflows/ci.yml

@@ -13,7 +13,7 @@ jobs:
         id: ci
         uses: ignition-tooling/action-ignition-ci@bionic
         with:
-          codecov-token: ${{ secrets.CODECOV_TOKEN }}
+          codecov-enabled: true
   focal-ci:
     runs-on: ubuntu-latest
     name: Ubuntu Focal CI

CMakeLists.txt

@@ -9,7 +9,7 @@ project(ignition-gazebo4 VERSION 4.8.0)
 # Find ignition-cmake
 #============================================================================
 # If you get an error at this line, you need to install ignition-cmake
-find_package(ignition-cmake2 2.3 REQUIRED)
+find_package(ignition-cmake2 2.8.0 REQUIRED)
 
 #============================================================================
 # Configure the project

include/ignition/gazebo/EntityComponentManager.hh

@@ -409,8 +409,11 @@ namespace ignition
       /// return false to stop subsequent calls to the callback, otherwise
       /// a true value should be returned.
       /// \tparam ComponentTypeTs All the desired component types.
-      /// \warning This function should not be called outside of System's
-      /// PreUpdate, callback. The result of call after PreUpdate is invalid
+      /// \warning Since entity creation occurs during PreUpdate, this function
+      /// should not be called in a System's PreUpdate callback (it's okay to
+      /// call this function in the Update callback). If you need to call this
+      /// function in a system's PostUpdate callback, you should use the const
+      /// version of this method.
       public: template <typename... ComponentTypeTs>
               void EachNew(typename identity<std::function<
                            bool(const Entity &_entity,
@@ -425,8 +428,9 @@ namespace ignition
       /// return false to stop subsequent calls to the callback, otherwise
       /// a true value should be returned.
       /// \tparam ComponentTypeTs All the desired component types.
-      /// \warning This function should not be called outside of System's
-      /// PreUpdate, callback. The result of call after PreUpdate is invalid
+      /// \warning Since entity creation occurs during PreUpdate, this function
+      /// should not be called in a System's PreUpdate callback (it's okay to
+      /// call this function in the Update or PostUpdate callback).
       public: template <typename... ComponentTypeTs>
               void EachNew(typename identity<std::function<
                            bool(const Entity &_entity,

src/gui/plugins/component_inspector/ComponentInspector.cc

@@ -431,6 +431,12 @@ void ComponentInspector::Update(const UpdateInfo &,
       continue;
     }
 
+    if (typeId == components::Light::typeId)
+    {
+      this->SetType("light");
+      continue;
+    }
+
     if (typeId == components::Actor::typeId)
     {
       this->SetType("actor");