Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Louise Poubel <[email protected]>
  • Loading branch information
chapulina committed Jul 29, 2021
1 parent 673388d commit 8025da6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions include/ignition/gazebo/Util.hh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#define IGNITION_GAZEBO_UTIL_HH_

#include <string>
#include <unordered_set>
#include <vector>

#include <ignition/math/Pose3.hh>
Expand Down Expand Up @@ -72,8 +73,8 @@ namespace ignition
/// the scoped name could be relative to any entity.
/// \param[in] _delim Delimiter between names, defaults to "::", it can't
/// be empty.
/// \return The entity or kNullEntity if no entity was found with that
/// name.
/// \return All entities that match the scoped name and relative to
/// requirements, or an empty set otherwise.
std::unordered_set<Entity> IGNITION_GAZEBO_VISIBLE entitiesFromScopedName(
const std::string &_scopedName, const EntityComponentManager &_ecm,
Entity _relativeTo = kNullEntity,
Expand Down
5 changes: 3 additions & 2 deletions src/Util_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,9 @@ TEST_F(UtilTest, EntitiesFromScopedName)
auto orange14 = createEntity("orange", orange13);
auto pear15 = createEntity("pear", grape11);

auto checkEntities = [&ecm](const std::string &_scopedName, Entity _relativeTo,
const std::unordered_set<Entity> &_result, const std::string &_delim)
auto checkEntities = [&ecm](const std::string &_scopedName,
Entity _relativeTo, const std::unordered_set<Entity> &_result,
const std::string &_delim)
{
auto res = gazebo::entitiesFromScopedName(_scopedName, ecm, _relativeTo,
_delim);
Expand Down

0 comments on commit 8025da6

Please sign in to comment.