Skip to content

Commit

Permalink
Remove major version from plugin name references
Browse files Browse the repository at this point in the history
Signed-off-by: Steve Peters <[email protected]>
  • Loading branch information
scpeters committed Jan 23, 2025
1 parent 5529406 commit 9cfe829
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 15 deletions.
4 changes: 1 addition & 3 deletions src/ServerPrivate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ struct LoggingPlugin
/// \return A string that contains the record plugin file name.
public: static std::string &LoggingPluginFileName()
{
static std::string recordPluginFileName =
std::string("gz-sim") +
GZ_SIM_MAJOR_VERSION_STR + "-log-system";
static std::string recordPluginFileName = "gz-sim-log-system";
return recordPluginFileName;
}

Expand Down
11 changes: 4 additions & 7 deletions src/SystemLoader_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,9 @@ TEST(SystemLoader, Constructor)
sdf::Root root;
root.LoadSdfString(std::string("<?xml version='1.0'?><sdf version='1.6'>"
"<world name='default'>") +
"<plugin filename='libgz-sim" +
GZ_SIM_MAJOR_VERSION_STR + "-user-commands-system.so' "
"<plugin filename='libgz-sim-user-commands-system.so' "
"name='gz::sim::systems::UserCommands'></plugin>"
"<plugin filename='gz-sim" +
GZ_SIM_MAJOR_VERSION_STR + "-user-commands-system' "
"<plugin filename='gz-sim-user-commands-system' "
"name='gz::sim::systems::UserCommands'></plugin>"
"<plugin filename='gz-sim-user-commands-system' "
"name='gz::sim::systems::UserCommands'></plugin>"
Expand Down Expand Up @@ -198,10 +196,9 @@ TEST(SystemLoader, BadPluginName)
sdf::Root root;
root.LoadSdfString(std::string("<?xml version='1.0'?><sdf version='1.6'>"
"<world name='default'>"
"<plugin filename='libgz-sim") +
GZ_SIM_MAJOR_VERSION_STR + "-physics-system.so' "
"<plugin filename='libgz-sim-physics-system.so' "
"name='gz::sim::systems::Foo'></plugin>"
"</world></sdf>");
"</world></sdf>"));

auto worldElem = root.WorldByIndex(0)->Element();
if (worldElem->HasElement("plugin")) {
Expand Down
8 changes: 3 additions & 5 deletions test/test_config.hh.in
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,15 @@ struct TestWorldSansPhysics
"<gz:policies>"
" <include_server_config_plugins>false</include_server_config_plugins>"
"</gz:policies>"
"<plugin filename='libgz-sim") +
GZ_SIM_MAJOR_VERSION_STR + "-scene-broadcaster-system.so'"
"<plugin filename='libgz-sim-scene-broadcaster-system.so'"
" name='gz::sim::systems::SceneBroadcaster'>"
"</plugin>"
"<plugin"
" filename='libgz-sim" +
GZ_SIM_MAJOR_VERSION_STR + "-user-commands-system.so'"
" filename='libgz-sim-user-commands-system.so'"
" name='gz::sim::systems::UserCommands'>"
"</plugin>"
"</world>"
"</sdf>";
"</sdf>");
return world;
}
};
Expand Down

0 comments on commit 9cfe829

Please sign in to comment.