Skip to content

Commit

Permalink
Protobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2) (#…
Browse files Browse the repository at this point in the history
…2006)

Signed-off-by: Silvio Traversaro <[email protected]>

* TriggeredPublisher: don't catch FatalException
  It has been removed from recent versions of protobuf.

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
  • Loading branch information
traversaro and scpeters committed Jun 15, 2023
1 parent 1038a35 commit b61f914
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 10 deletions.
2 changes: 0 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,7 @@ set(IGN_TOOLS_VER 1)

#--------------------------------------
# Find protobuf
set(REQ_PROTOBUF_VER 3)
ign_find_package(IgnProtobuf
VERSION ${REQ_PROTOBUF_VER}
REQUIRED
COMPONENTS all
PRETTY Protobuf)
Expand Down
9 changes: 1 addition & 8 deletions src/systems/triggered_publisher/TriggeredPublisher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -652,14 +652,7 @@ bool TriggeredPublisher::MatchInput(const transport::ProtoMsg &_inputMsg)
return std::all_of(this->matchers.begin(), this->matchers.end(),
[&](const auto &_matcher)
{
try
{
return _matcher->Match(_inputMsg);
} catch (const google::protobuf::FatalException &err)
{
ignerr << err.what() << std::endl;
return false;
}
return _matcher->Match(_inputMsg);
});
}

Expand Down

0 comments on commit b61f914

Please sign in to comment.