Remove unused ignition gui header #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #1026 +/- ##
===============================================
- Coverage 67.14% 67.10% -0.04%
===============================================
Files 243 243
Lines 18212 18212
===============================================
- Hits 12229 12222 -7
- Misses 5983 5990 +7
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 14, 2021
chapulina
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including
guiheaders requires inclusion/linking of ignition-gui as well as Qt, which is LGPL licensed.This eliminates the dependency.
Signed-off-by: Michael Carroll [email protected]