Fix crash on resize #1028
Merged
Fix crash on resize #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
+ Coverage 63.26% 63.34% +0.08%
==========================================
Files 239 239
Lines 19465 19464 -1
==========================================
+ Hits 12314 12329 +15
+ Misses 7151 7135 -16
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Sep 15, 2021
|
@osrf-jenkins retest this please |
mjcarroll
approved these changes
Sep 15, 2021
2 tasks
chapulina
added
beta
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Ian Chen <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Fixes gazebosim/gz-rendering#408
Summary
Fix crash when resizing ign-gazebo gui window
ign-rendering6 enforces a strict order of render calls (prerender -> render -> postrender) in order to achieve efficient use of resources. If we run into more issues / crashes like this in the future, we should probably just print a warning (and auto recover from a bad state) instead of exiting on an assert.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge