-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable specific entities on buoyancy plugin #1067
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this. It seems to work for me. There are some style fixes required before merging though.
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1067 +/- ##
=======================================
Coverage 64.06% 64.06%
=======================================
Files 255 255
Lines 19963 19986 +23
=======================================
+ Hits 12790 12805 +15
- Misses 7173 7181 +8
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
I've addressed all comments, merging! |
🦟 Bug fix
This is technically a feature, but it fixes a usability bug that affects the Fortress demo.
Summary
Adds the ability of whitelisting just a few models in simulation which will be affected by buoyancy.
Also reduced console spam by printing a warning only once.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸