Suppress missing canonical link error messages for static models #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <[email protected]>
chapulina
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 64.07% 64.09% +0.02%
==========================================
Files 255 255
Lines 19958 19961 +3
==========================================
+ Hits 12788 12795 +7
+ Misses 7170 7166 -4
Continue to review full report at Codecov.
|
azeey
approved these changes
Sep 29, 2021
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
…ebosim#1068) Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig [email protected]
🦟 Bug fix
Summary
Erroneous error messages are generated if a static model lacks a link.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge