Fix crash when running the Gazebo GUI #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was caused by an access to an invalid address within Qt when trying to access the command line arguments to the application. These are passed as argc and argv to QApplication, but for argc, we were passing a reference to a local. Signed-off-by: Addisu Z. Taddese <[email protected]>
|
Builds and runs fine for me now! |
JShep1
approved these changes
Apr 28, 2020
iche033
approved these changes
Apr 28, 2020
chapulina
approved these changes
Apr 28, 2020
nkoenig
pushed a commit
that referenced
this pull request
May 6, 2020
The crash was caused by an access to an invalid address within Qt when trying to access the command line arguments to the application. These are passed as argc and argv to QApplication, but for argc, we were passing a reference to a local. Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Nate Koenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash (introduced in PR #79) was caused by an access to an invalid address within Qt when
trying to access the command line arguments to the application. These
are passed as argc and argv to QApplication, but for argc, we were
passing a reference to a local.