Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform controls #1081

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix transform controls #1081

merged 1 commit into from
Oct 5, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Since gazebosim/gz-gui#295, the "click" events are only emitted on release. For press and drag, new events are needed.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested review from nkoenig and iche033 October 2, 2021 00:49
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 2, 2021
@chapulina chapulina added the bug Something isn't working label Oct 2, 2021
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #1081 (042112e) into ign-gazebo6 (9d6157e) will decrease coverage by 0.05%.
The diff coverage is 22.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1081      +/-   ##
===============================================
- Coverage        64.12%   64.06%   -0.06%     
===============================================
  Files              255      255              
  Lines            19994    20002       +8     
===============================================
- Hits             12821    12815       -6     
- Misses            7173     7187      +14     
Impacted Files Coverage Δ
.../gui/plugins/transform_control/TransformControl.cc 7.34% <22.22%> (+0.36%) ⬆️
...int_position_controller/JointPositionController.cc 53.14% <0.00%> (-5.15%) ⬇️
src/EntityComponentManager.cc 85.48% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6157e...042112e. Read the comment docs.

@iche033
Copy link
Contributor

iche033 commented Oct 2, 2021

fixes the transform issue for me.

I noticed in this branch, there are more camera jumps if I drag the mouse to pan / orbit the camera quickly, especially the very first click and drag after launch. This can be addressed separately.

@chapulina chapulina merged commit 30c6df0 into ign-gazebo6 Oct 5, 2021
@chapulina chapulina deleted the chapulina/fix_transforms branch October 5, 2021 01:08
srmainwaring pushed a commit to srmainwaring/gz-sim that referenced this pull request Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants