Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix View Angle's home button #1082

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

On #1016 I forgot to make sure the home button works. This fixes it.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the bug Something isn't working label Oct 2, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Oct 2, 2021
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #1082 (ecefdb6) into ign-gazebo6 (9d6157e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1082      +/-   ##
===============================================
- Coverage        64.12%   64.07%   -0.05%     
===============================================
  Files              255      255              
  Lines            19994    19994              
===============================================
- Hits             12821    12812       -9     
- Misses            7173     7182       +9     
Impacted Files Coverage Δ
...int_position_controller/JointPositionController.cc 53.14% <0.00%> (-5.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6157e...ecefdb6. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@chapulina chapulina merged commit 6ab576d into ign-gazebo6 Oct 4, 2021
@chapulina chapulina deleted the chapulina/6/fix_home_angle branch October 4, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants