-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GUI config folder before copying config #1092
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1092 +/- ##
===============================================
+ Coverage 64.07% 64.08% +0.01%
===============================================
Files 255 255
Lines 20051 20064 +13
===============================================
+ Hits 12847 12859 +12
- Misses 7204 7205 +1
Continue to review full report at Codecov.
|
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
68cbf42
to
09d5101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I fixed one instance on #1070, but forgot about this one.
I rebased to ign-gazebo6
and pushed a style fix, plus an extra check.
@osrf-jenkins retest this please. |
🦟 Bug fix
Fixes #
I should have filed an issue for this, however this is a tiny fix so...
Basically when I was running some worlds of my own I came accross the following error
Summary
Turns out we were not creating the directories before copying the config files.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge