Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GUI config folder before copying config #1092

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Oct 7, 2021

🦟 Bug fix

Fixes #
I should have filed an issue for this, however this is a tiny fix so...

Basically when I was running some worlds of my own I came accross the following error

[GUI] [Wrn] [Filesystem.cc:376] Failed to create file [/home/arjo/.ignition/gazebo/6/gui.config]: No such file or directory
[GUI] [Err] [Gui.cc:269] Failed to copy installed config [/home/arjo/workspaces/ign_ws/install/share/ignition/ignition-gazebo6/gui/gui.config] to default config [/home/arjo/.ignition/gazebo/6/gui.config].
[GUI] [Dbg] [Application.cc:130] Terminating application.
[Dbg] [SignalHandler.cc:141] Received signal[2].
[Dbg] [ServerPrivate.cc:106] Server received signal[2]
[Msg] Found no publishers on /stats, adding root stats topic
[Msg] Found no publishers on /clock, adding root clock topic
[Dbg] [ign.cc:356] Shutting down ign-gazebo-server

Summary

Turns out we were not creating the directories before copying the config files.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@arjo129 arjo129 changed the base branch from ign-gazebo5 to main October 7, 2021 01:37
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Oct 7, 2021
@arjo129 arjo129 added 🏯 fortress Ignition Fortress and removed 🏢 edifice Ignition Edifice labels Oct 7, 2021
@azeey azeey removed their request for review October 7, 2021 01:41
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1092 (09d5101) into ign-gazebo6 (c603710) will increase coverage by 0.01%.
The diff coverage is 46.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1092      +/-   ##
===============================================
+ Coverage        64.07%   64.08%   +0.01%     
===============================================
  Files              255      255              
  Lines            20051    20064      +13     
===============================================
+ Hits             12847    12859      +12     
- Misses            7204     7205       +1     
Impacted Files Coverage Δ
src/gui/Gui.cc 61.97% <46.66%> (-2.37%) ⬇️
src/gui/plugins/plot_3d/Plot3D.cc 47.82% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c603710...09d5101. Read the comment docs.

arjo129 and others added 4 commits October 7, 2021 09:59
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina force-pushed the arjo/fix/gui_config_copying branch from 68cbf42 to 09d5101 Compare October 7, 2021 17:06
@chapulina chapulina changed the base branch from main to ign-gazebo6 October 7, 2021 17:06
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I fixed one instance on #1070, but forgot about this one.

I rebased to ign-gazebo6 and pushed a style fix, plus an extra check.

@chapulina chapulina enabled auto-merge (squash) October 7, 2021 17:08
@arjo129
Copy link
Contributor Author

arjo129 commented Oct 8, 2021

@osrf-jenkins retest this please.

@chapulina chapulina disabled auto-merge October 8, 2021 03:12
@chapulina chapulina merged commit 614340c into ign-gazebo6 Oct 8, 2021
@chapulina chapulina deleted the arjo/fix/gui_config_copying branch October 8, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants