Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance level test flakiness #1129

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 20, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Closes #826

Summary

Fixes the PERFORMANCE_level_manager by running the server once before measuring.

Test it

Run the test with and without the change. You should see a big difference in the time Using levels = X ms.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@nkoenig nkoenig requested a review from chapulina as a code owner October 20, 2021 21:18
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1129 (38784b7) into ign-gazebo3 (0640db9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3    #1129   +/-   ##
============================================
  Coverage        77.70%   77.70%           
============================================
  Files              222      222           
  Lines            12716    12716           
============================================
  Hits              9881     9881           
  Misses            2835     2835           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0640db9...38784b7. Read the comment docs.

@nkoenig nkoenig merged commit f88e074 into ign-gazebo3 Oct 20, 2021
@nkoenig nkoenig deleted the fix_flaky_level_performance_test branch October 20, 2021 22:35
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants