use uint64_t for ComponentInspector Entity IDs #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
adlarkin
changed the title
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1144 +/- ##
================================================
- Coverage 77.70% 63.73% -13.98%
================================================
Files 222 256 +34
Lines 12716 20117 +7401
================================================
+ Hits 9881 12821 +2940
- Misses 2835 7296 +4461
Continue to review full report at Codecov.
|
chapulina
approved these changes
Oct 26, 2021
iche033
approved these changes
Oct 26, 2021
7 tasks
Signed-off-by: Ashton Larkin <[email protected]>
adlarkin
force-pushed
the
adlarkin/compInspector_64bit_ID
branch
from
41f4732 to
36081cd
Compare
I have retargeted to Citadel and will merge if/when CI comes back green. |
adlarkin
added
🏰 citadel
srmainwaring
pushed a commit
to srmainwaring/gz-sim
that referenced
this pull request
Nov 11, 2021
Signed-off-by: Ashton Larkin <[email protected]>
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
Signed-off-by: Ashton Larkin <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin [email protected]
🦟 Bug fix
Summary
On the server, an Entity ID is defined as a uint64_t. This PR updates the component inspector to use the same type for entity IDs in the GUI plugin.
This should help with some of the issues seen in #1138.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge