Prevent creation of spurious <plugin> elements when saving worlds #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1192 +/- ##
============================================
Coverage 77.25% 77.25%
============================================
Files 227 227
Lines 13509 13509
============================================
Hits 10437 10437
Misses 3072 3072
Continue to review full report at Codecov.
|
chapulina
approved these changes
Nov 11, 2021
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
…zebosim#1192) Spurious <plugin> elements were created when saving worlds because sdf::Element::GetElement was used to check if a <plugin> child element exists. However this function always creates a new element if the element does not exist instead of returning a nullptr. The solution is to use sdf::Element::FindElement instead. Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Spurious
<plugin>elements were created when saving worlds becausesdf::Element::GetElementwas used to check if a<plugin>child element exists. However this function always creates a new element if the element does not exist instead of returning anullptr. The solution is to usesdf::Element::FindElementinstead.Checklist
[ ] Updated documentation (as needed)[ ] Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge