Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user commands light test on macOS #1204

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Part of #634

Summary

The test fails consistently, see its history:

https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo4-homebrew-amd64/102/testReport/(root)/INTEGRATION_user_commands/test_ran/history/

Let's disable it until we have time to look for an actual fix.

Checklist

  • Signed all commits for DCO
  • Added Removed tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@github-actions github-actions bot added the 🔮 dome Ignition Dome label Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1204 (7c41404) into ign-gazebo4 (f8942cd) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1204      +/-   ##
===============================================
+ Coverage        66.40%   66.41%   +0.01%     
===============================================
  Files              250      250              
  Lines            19256    19256              
===============================================
+ Hits             12787    12789       +2     
+ Misses            6469     6467       -2     
Impacted Files Coverage Δ
src/network/PeerInfo.cc 100.00% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8942cd...7c41404. Read the comment docs.

@chapulina chapulina merged commit 5168544 into ign-gazebo4 Nov 19, 2021
@chapulina chapulina deleted the chapulina/4/disable_light_macos branch November 19, 2021 17:47
@chapulina chapulina added tests Broken or missing tests / testing infra macOS macOS support labels Nov 19, 2021
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome macOS macOS support tests Broken or missing tests / testing infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants