Bumps in garden: use ign-math7 and dependents #1264

chapulina · 2021-12-27T18:00:39Z

Signed-off-by: Louise Poubel <[email protected]>

chapulina · 2021-12-30T04:45:36Z

The TriggeredPublisher test failures seem to be caused by SDFormat:

173: [ RUN      ] TriggeredPublisherTest.EmptyInputEmptyOutput
173: [Msg] Loading SDF world file[/home/jenkins/workspace/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/ign-gazebo/test/worlds/triggered_publisher.sdf].
173: Error [Param.cc:768] Unknown parameter type[ignition.msgs.Boolean]
173: Exception [Param.cc:81] SDF ASSERTION                     
173: Invalid parameter
173: In function       : Param
173: Assert expression : this->dataPtr->ValueFromStringImpl( this->dataPtr->typeName, _default, this->dataPtr->defaultValue)
173: unknown file: Failure
173: Unknown C++ exception thrown in SetUp().

It may already be on main, but we can't trigger a test build because we're in the middle of the dependency bump.

Signed-off-by: Steve Peters <[email protected]>

scpeters · 2021-12-30T16:41:43Z

The TriggeredPublisher test failures seem to be caused by SDFormat:

173: [ RUN      ] TriggeredPublisherTest.EmptyInputEmptyOutput
173: [Msg] Loading SDF world file[/home/jenkins/workspace/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/ign-gazebo/test/worlds/triggered_publisher.sdf].
173: Error [Param.cc:768] Unknown parameter type[ignition.msgs.Boolean]
173: Exception [Param.cc:81] SDF ASSERTION                     
173: Invalid parameter
173: In function       : Param
173: Assert expression : this->dataPtr->ValueFromStringImpl( this->dataPtr->typeName, _default, this->dataPtr->defaultValue)
173: unknown file: Failure
173: Unknown C++ exception thrown in SetUp().

It may already be on main, but we can't trigger a test build because we're in the middle of the dependency bump.

Observations:

The test failures happen on both Ubuntu and homebrew.
I don't see these test failures on ign-gazebo6 using the latest stable release of libsdformat12:
- https://build.osrfoundation.org/view/ign-fortress/job/ignition_gazebo-ci-ign-gazebo6-bionic-amd64/
I've looked at some branch comparisons of sdformat and ign-gazebo and don't see any significant differences between main and the previous stable branch that indicate a cause of this problem
- https://github.com/ignitionrobotics/sdformat/compare/main
- https://github.com/ignitionrobotics/ign-gazebo/compare/main
I do, however, see a substantial number of unreleased changes on sdf12 that have not been tested by any of ign-gazebo's Ubuntu or homebrew builds
- gazebosim/sdformat@sdformat12_12.3.0...sdf12

I suggest a prerelease of libsdformat12

scpeters · 2021-12-30T16:42:38Z

I suggest a prerelease of libsdformat12

and I think we should disable the triggered publisher tests so we can finish this merge

scpeters · 2021-12-30T16:44:59Z

I suspect gazebosim/sdformat#689 for the TriggeredPublisher test failures

chapulina · 2021-12-30T17:23:26Z

I think we should disable the triggered publisher tests so we can finish this merge

Since ign-gazebo already has other failing / flaky tests, I think it's ok to leave those failing so we remember to address them quickly.

I suggest a prerelease of libsdformat12

I can reproduce the failure locally on a Fortress workspace, so we don't need the pre-release to confirm the issue. Let me take a stab at it, hopefully it's an easy fix.

scpeters · 2021-12-30T18:00:23Z

I suspect ignitionrobotics/sdformat#689 for the TriggeredPublisher test failures

I've commented https://github.com/ignitionrobotics/sdformat/pull/689/files#r776821783 on the line I believe to be causing the problem

scpeters · 2021-12-30T18:12:16Z

I think we should disable the triggered publisher tests so we can finish this merge

Since ign-gazebo already has other failing / flaky tests, I think it's ok to leave those failing so we remember to address them quickly.

the triggered publisher failures were the only problems with the following build:

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/7759

I think it's worth disabling the builds before merging this rather than merging them if we know they will always be failing

I suggest a prerelease of libsdformat12

I can reproduce the failure locally on a Fortress workspace, so we don't need the pre-release to confirm the issue. Let me take a stab at it, hopefully it's an easy fix.

if not a prerelease, perhaps we could trigger some nightly builds of libsdformat12? I think it will be easier to confirm the fix if we have debs that we can use from CI builds. An alternative would be building an entire workspace from source from a specified .repos file like the ROS2 CI

chapulina · 2021-12-30T18:22:23Z

I think it's worth disabling the builds before merging this rather than merging them if we know they will always be failing

Ok, disabling those tests, right? We'll just need another PR to re-enable them soon.

An alternative would be building an entire workspace from source from a specified .repos file like the ROS2 CI

Yeah we can do that with GitHub actions. I'm hoping to open a PR upstream soon with a band-aid that we can test against ign-gazebo. Or are you saying we should test the current sdf12 branch to confirm the issue?

chapulina · 2021-12-30T18:39:52Z

@scpeters , what do you think of not blocking this on the triggered publisher issue? I'd like to finish bumping ign-launch and ign-garden today. If you feel strongly about disabling the tests on this PR I can do that now, just let me know. The issue is coming from ign-gazebo6, so disabling them here only solves part of the issue.

An alternative would be building an entire workspace from source from a specified .repos file like the ROS2 CI
Yeah we can do that with GitHub actions.

See Build SDF from source to reproduce test failures #1266

scpeters · 2021-12-30T18:43:37Z

@scpeters , what do you think of not blocking this on the triggered publisher issue? I'd like to finish bumping ign-launch and ign-garden today. If you feel strongly about disabling the tests on this PR I can do that now, just let me know. The issue is coming from ign-gazebo6, so disabling them here only solves part of the issue.

An alternative would be building an entire workspace from source from a specified .repos file like the ROS2 CI
Yeah we can do that with GitHub actions.

See Build SDF from source to reproduce test failures #1266

yes we should disable the triggered publisher test

Signed-off-by: Louise Poubel <[email protected]>

…thub.com/ignitionrobotics/ign-gazebo into ci_matching_branch/bump_garden_ign-gazebo7 Signed-off-by: Louise Poubel <[email protected]>

chapulina · 2021-12-30T18:51:25Z

yes we should disable the triggered publisher test

Ok, disabled in faf7533

scpeters · 2021-12-30T19:36:41Z

yes we should disable the triggered publisher test

Ok, disabled in faf7533

to remind us to reenable the tests: #1267

codecov · 2021-12-30T20:23:54Z

Codecov Report

Merging #1264 (662508d) into main (0e720f0) will decrease coverage by 0.23%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   61.95%   61.71%   -0.24%     
==========================================
  Files         276      274       -2     
  Lines       22996    22740     -256     
==========================================
- Hits        14248    14035     -213     
+ Misses       8748     8705      -43

Impacted Files	Coverage Δ
include/ignition/gazebo/gui/GuiEvents.hh	`0.00% <ø> (ø)`
...lization_capabilities/VisualizationCapabilities.cc	`3.70% <0.00%> (ø)`
src/rendering/SceneManager.cc	`25.99% <0.00%> (ø)`
src/systems/track_controller/TrackController.cc	`70.94% <0.00%> (ø)`
...ems/collada_world_exporter/ColladaWorldExporter.cc	`94.81% <100.00%> (ø)`
src/systems/multicopter_control/Common.cc	`71.42% <100.00%> (ø)`
.../systems/triggered_publisher/TriggeredPublisher.cc
.../systems/triggered_publisher/TriggeredPublisher.hh
src/systems/buoyancy/Buoyancy.cc	`83.09% <0.00%> (+0.07%)`	⬆️
src/systems/physics/Physics.cc	`71.65% <0.00%> (+0.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e720f0...662508d. Read the comment docs.

chapulina · 2021-12-30T20:51:44Z

Merging this and its related infrastructure PRs:

Bumps in garden: ign-math7, ign-common5, sdformat13 and ign-physics6 gazebo-release/gz-sim7-release#3
Bumps in garden: ign-gazebo7 use ign-math7, ign-common5, sdformat13 and ign-physics6 osrf/homebrew-simulation#1762
Bumps in garden: ign-gazebo7 use ign-math7, ign-common5, sdformat13 and ign-physics6 gazebo-tooling/gazebodistro#70

Bumps in garden : ci_matching_branch/bump_garden_ign-gazebo7

7698c01

Signed-off-by: Louise Poubel <[email protected]>

chapulina requested a review from mabelzhang as a code owner December 27, 2021 18:00

github-actions bot added the 🌱 garden Ignition Garden label Dec 27, 2021

chapulina requested a review from scpeters December 27, 2021 22:45

chapulina added the needs upstream release Blocked by a release of an upstream library label Dec 27, 2021

chapulina mentioned this pull request Dec 28, 2021

5 ➡️ 6 (main) gazebosim/gz-physics#321

Merged

Updates for deprecations

fdae16a

Signed-off-by: Louise Poubel <[email protected]>

chapulina requested a review from iche033 as a code owner December 28, 2021 01:58

caguero approved these changes Dec 28, 2021

View reviewed changes

chapulina removed the needs upstream release Blocked by a release of an upstream library label Dec 29, 2021

scpeters changed the title ~~Bumps in garden : ci_matching_branch/bump_garden_ign-gazebo7~~ Bumps in garden: use ign-math7 and dependents Dec 30, 2021

make event visible for Windows

fdb4a3c

Signed-off-by: Louise Poubel <[email protected]>

SdfGenerator_TEST: fix expected URI

5dc4821

Signed-off-by: Steve Peters <[email protected]>

scpeters mentioned this pull request Dec 30, 2021

Support printing sdf poses in degrees and allow snapping to commonly used angles gazebosim/sdformat#689

Merged

8 tasks

This was referenced Dec 30, 2021

Fix parsing 'type' attibutes in plugins gazebosim/sdformat#809

Merged

Build SDF from source to reproduce test failures #1266

Closed

chapulina added 2 commits December 30, 2021 10:50

Disable triggered_publisher test

faf7533

Signed-off-by: Louise Poubel <[email protected]>

Merge branch 'ci_matching_branch/bump_garden_ign-gazebo7' of ssh://gi…

662508d

…thub.com/ignitionrobotics/ign-gazebo into ci_matching_branch/bump_garden_ign-gazebo7 Signed-off-by: Louise Poubel <[email protected]>

scpeters mentioned this pull request Dec 30, 2021

Triggered publisher tests are disabled on ign-gazebo7 (main) #1267

Closed

scpeters approved these changes Dec 30, 2021

View reviewed changes

chapulina merged commit a95a584 into main Dec 30, 2021

chapulina deleted the ci_matching_branch/bump_garden_ign-gazebo7 branch December 30, 2021 20:51

chapulina mentioned this pull request Jan 4, 2022

Re-enable triggered publisher tests #1271

Merged

7 tasks

j-rivero mentioned this pull request Sep 16, 2022

Rename python library as gz.sim7 #1716

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumps in garden: use ign-math7 and dependents #1264

Bumps in garden: use ign-math7 and dependents #1264

chapulina commented Dec 27, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021 •

edited

Loading

scpeters commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

codecov bot commented Dec 30, 2021 •

edited

Loading

chapulina commented Dec 30, 2021

Bumps in garden: use ign-math7 and dependents #1264

Bumps in garden: use ign-math7 and dependents #1264

Conversation

chapulina commented Dec 27, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021 • edited Loading

scpeters commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021

codecov bot commented Dec 30, 2021 • edited Loading

Codecov Report

chapulina commented Dec 30, 2021

scpeters commented Dec 30, 2021 •

edited

Loading

codecov bot commented Dec 30, 2021 •

edited

Loading