Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add world force #1279

Merged
merged 12 commits into from
Jan 13, 2022
Merged

Add world force #1279

merged 12 commits into from
Jan 13, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Jan 11, 2022

🎉 New feature

Summary

This PR extends the Link class with the ability to apply a force with an offset.

Thanks to @azeey for all the physics tips!

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

caguero and others added 8 commits December 24, 2021 16:29
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 11, 2022
@chapulina chapulina added the physics Involves Ignition Physics label Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1279 (b6ec8a7) into ign-gazebo6 (989cd28) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1279      +/-   ##
===============================================
+ Coverage        62.22%   62.23%   +0.01%     
===============================================
  Files              278      278              
  Lines            23122    23131       +9     
===============================================
+ Hits             14387    14396       +9     
  Misses            8735     8735              
Impacted Files Coverage Δ
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
src/Link.cc 93.98% <88.88%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989cd28...b6ec8a7. Read the comment docs.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Copy link
Contributor

iche033 commented Jan 11, 2022

added test in d1676c3. Marking this PR as ready.

@iche033 iche033 marked this pull request as ready for review January 11, 2022 23:02
@iche033 iche033 requested a review from chapulina as a code owner January 11, 2022 23:02
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me.

@caguero caguero merged commit 19aba6d into ign-gazebo6 Jan 13, 2022
@caguero caguero deleted the add_world_force branch January 13, 2022 14:49
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-24-citadel-edifice-fortress/1241/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress physics Involves Ignition Physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants