Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add worldEntity util #1308

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

chapulina
Copy link
Contributor

When I suggested removing the configure callback until we found a way to handle the EventManager, I didn't realize this would make the example kinda meaningless (i.e. not checking world gravity). Here's a suggestion to wrap the worldEntity function so we can get the entity in an update call, without relying on Configure.

Also added a few more suggestions:

  • Move example to its own directory in examples/scripts. This way we can add other python examples there later too.
  • Added a README to the example
  • Minor updates to remove configure and left-over comments.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from ahcorde January 25, 2022 02:18
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1308 (1e03834) into ahcorde/python/gazebo (5619121) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           ahcorde/python/gazebo    #1308      +/-   ##
=========================================================
- Coverage                  62.25%   62.25%   -0.01%     
=========================================================
  Files                        278      278              
  Lines                      23203    23203              
=========================================================
- Hits                       14446    14445       -1     
- Misses                      8757     8758       +1     
Impacted Files Coverage Δ
include/ignition/gazebo/EventManager.hh 79.16% <ø> (ø)
src/EntityComponentManager.cc 88.26% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5619121...1e03834. Read the comment docs.

@ahcorde ahcorde merged commit 3eb5691 into ahcorde/python/gazebo Jan 25, 2022
@ahcorde ahcorde deleted the chapulina/6/python branch January 25, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants