Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #1422

Merged
merged 4 commits into from
Apr 4, 2022
Merged

5 ➡️ 6 #1422

merged 4 commits into from
Apr 4, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo5 to ign-gazebo6

Branch comparison: ign-gazebo6...ign-gazebo5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ivanpauno and others added 4 commits March 28, 2022 18:31
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
…azebo classic (#1331)

This system can be used to generate thumbnails of models. In comparison to the Modelpropshop plugin in Gazebo classic, this adds the ability to generate thumbnails after randomizing the joint positions of the model.

Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from ahcorde April 1, 2022 20:17
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 1, 2022
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1422 (fa2d7cc) into ign-gazebo6 (685a11f) will increase coverage by 0.31%.
The diff coverage is 68.66%.

❗ Current head fa2d7cc differs from pull request most recent head 8c8c7fa. Consider uploading reports for the commit 8c8c7fa to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1422      +/-   ##
===============================================
+ Coverage        63.04%   63.36%   +0.31%     
===============================================
  Files              303      306       +3     
  Lines            24385    24715     +330     
===============================================
+ Hits             15374    15660     +286     
- Misses            9011     9055      +44     
Impacted Files Coverage Δ
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
src/rendering/SceneManager.cc 28.27% <0.00%> (+1.89%) ⬆️
src/systems/sensors/Sensors.cc 65.00% <10.25%> (-3.88%) ⬇️
src/systems/user_commands/UserCommands.cc 53.33% <49.10%> (-0.67%) ⬇️
src/systems/wheel_slip/WheelSlip.cc 66.41% <78.94%> (+1.46%) ⬆️
src/Server.cc 89.72% <81.48%> (+3.58%) ⬆️
src/Util.cc 92.16% <83.33%> (-1.38%) ⬇️
src/systems/model_photo_shoot/ModelPhotoShoot.cc 91.26% <91.26%> (ø)
include/ignition/gazebo/components/WheelSlipCmd.hh 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a0ce3...8c8c7fa. Read the comment docs.

@j-rivero j-rivero merged commit 207d079 into ign-gazebo6 Apr 4, 2022
@j-rivero j-rivero deleted the chapulina/5_to_6 branch April 4, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants