Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extruded 2D polyline geometries #1456

Merged
merged 6 commits into from
May 12, 2022
Merged

Extruded 2D polyline geometries #1456

merged 6 commits into from
May 12, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Apr 22, 2022

🎉 New feature

Summary

Support extruded polyline geometries as visuals or collisions.

Test it

Try the example world:

ign gazebo polylines.sdf

polylines

TODO

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added rendering Involves Ignition Rendering physics Involves Ignition Physics labels Apr 22, 2022
@chapulina chapulina requested review from azeey and iche033 as code owners April 22, 2022 05:13
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 22, 2022
@chapulina chapulina linked an issue Apr 22, 2022 that may be closed by this pull request
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Apr 26, 2022
@chapulina chapulina requested a review from quarkytale May 2, 2022 19:35
@chapulina
Copy link
Contributor Author

Note to self: when forward-porting to Fortess, add collision visualization, see c87ddbb

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

I backported the linter fix from #661 and broke the CreatePhysicsEntities function apart in 34c7026

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-gazebo3@5994f6d). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             ign-gazebo3    #1456   +/-   ##
==============================================
  Coverage               ?   34.67%           
==============================================
  Files                  ?       31           
  Lines                  ?     1993           
  Branches               ?        0           
==============================================
  Hits                   ?      691           
  Misses                 ?     1302           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5994f6d...34c7026. Read the comment docs.

Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Tried the "ignwarn" edge cases as well, works as expected.

@chapulina chapulina merged commit 738579d into ign-gazebo3 May 12, 2022
@chapulina chapulina deleted the chapulina/3/polyline branch May 12, 2022 15:17
chapulina added a commit that referenced this pull request May 16, 2022
* Extruded 2D polyline geometries (#1456)

Signed-off-by: Louise Poubel <[email protected]>

* View polyline collisions on the GUI (#1481)

Signed-off-by: Louise Poubel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim physics Involves Ignition Physics rendering Involves Ignition Rendering
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support polylines
2 participants