-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extruded 2D polyline geometries #1456
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Note to self: when forward-porting to Fortess, add collision visualization, see c87ddbb |
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #1456 +/- ##
==============================================
Coverage ? 34.67%
==============================================
Files ? 31
Lines ? 1993
Branches ? 0
==============================================
Hits ? 691
Misses ? 1302
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Tried the "ignwarn" edge cases as well, works as expected.
* Extruded 2D polyline geometries (#1456) Signed-off-by: Louise Poubel <[email protected]> * View polyline collisions on the GUI (#1481) Signed-off-by: Louise Poubel <[email protected]>
🎉 New feature
Summary
Support extruded polyline geometries as visuals or collisions.
Test it
Try the example world:
TODO
CreatePhysicsEntities
function. I'll open a separate PR breaking it apart like it was done forign-gazebo5
on Heightmap physics (with DART) 🏔️ #661Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸