Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sensors demo camera format change #1468

Merged
merged 2 commits into from
May 4, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 3, 2022

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Reverts an unintended change accidentally made in #1454 (91d77a5), that updates a camera's format in sensors_demo.sdf world. This PR reverts that format change.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from chapulina as a code owner May 3, 2022 03:19
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 3, 2022
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #1468 (639c14c) into ign-gazebo6 (3b0f911) will not change coverage.
The diff coverage is n/a.

❗ Current head 639c14c differs from pull request most recent head 48c5f3d. Consider uploading reports for the commit 48c5f3d to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1468   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0f911...48c5f3d. Read the comment docs.

@ahcorde ahcorde merged commit 66fa61a into ign-gazebo6 May 4, 2022
@ahcorde ahcorde deleted the revert_sensors_demo_change branch May 4, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants