Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rssi #1482

Merged
merged 4 commits into from
May 17, 2022
Merged

Adding rssi #1482

merged 4 commits into from
May 17, 2022

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 12, 2022

🎉 New feature

Summary

This PR adds the rssi value to the message sent between two robots using the comms infrastructure. This can be useful for estimating the range between the robots.

Test it

  • Run the tests.
  • Run the example:
  1. Launch Gazebo:
ign gazebo -v 4 <your_ws>/src/ign-gazebo/examples/worlds/rf_comms.sdf
  1. Launch a subscriber:
ign topic -e -t addr2/rx
  1. Launch a publisher:
cd <your_ws>/src/ign-gazebo/examples/standalone/comms
mkdir build && cd build
cmake ..
make
./publisher addr2

You should observe messages on the subscriber terminal with the new rssi field.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from chapulina as a code owner May 12, 2022 17:07
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just one very minor comment

src/systems/rf_comms/RFComms.cc Show resolved Hide resolved
@chapulina chapulina added the 🌱 garden Ignition Garden label May 13, 2022
@iche033 iche033 added the 🏯 fortress Ignition Fortress label May 14, 2022
@caguero caguero added the mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/ label May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1482 (91cf690) into ign-gazebo6 (2a419fe) will not change coverage.
The diff coverage is n/a.

❗ Current head 91cf690 differs from pull request most recent head f2359bc. Consider uploading reports for the commit f2359bc to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1482   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a419fe...f2359bc. Read the comment docs.

@caguero caguero merged commit f4198be into ign-gazebo6 May 17, 2022
@caguero caguero deleted the caguero/rssi branch May 17, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden mbzirc Sponsored by MBZIRC: https://github.com/osrf/mbzirc/
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants