Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes thruster stop when battery runs out. #1495

Merged
merged 4 commits into from
May 20, 2022

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented May 18, 2022

🦟 Bug fix

Summary

Previously the thruster system would not stop when the battery was out. Now if a battery is attached to the model, the thruster will automatically stop once the battery runs out.

Signed-off-by: Arjo Chakravarty [email protected]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Previously the thruster system would not stop when the battery of a system was out. Now if a battery is attached to the model, the thruster will automatically stop once the battery runs out.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from chapulina as a code owner May 18, 2022 06:49
Signed-off-by: Arjo Chakravarty <[email protected]>
src/systems/thruster/Thruster.cc Outdated Show resolved Hide resolved
src/systems/thruster/Thruster.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1495 (5519232) into ign-gazebo6 (f3686aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 5519232 differs from pull request most recent head f3adc7c. Consider uploading reports for the commit f3adc7c to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1495   +/-   ##
============================================
  Coverage        33.58%   33.58%           
============================================
  Files               44       44           
  Lines             2260     2260           
============================================
  Hits               759      759           
  Misses            1501     1501           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3686aa...f3adc7c. Read the comment docs.

@chapulina chapulina added the 🏯 fortress Ignition Fortress label May 18, 2022
Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from adityapande-1995 May 19, 2022 02:09
@arjo129 arjo129 enabled auto-merge (squash) May 20, 2022 01:37
@arjo129 arjo129 merged commit 62272db into ign-gazebo6 May 20, 2022
@arjo129 arjo129 deleted the arjo/fix/thruster_obey_battery branch May 20, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants