-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case for simulation reset with detachable joints #1511
Conversation
Signed-off-by: Michael Carroll <[email protected]>
42c266d
to
c74e0e3
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
+ Coverage 63.62% 63.64% +0.01%
==========================================
Files 330 330
Lines 25787 25925 +138
==========================================
+ Hits 16408 16500 +92
- Misses 9379 9425 +46
Continue to review full report at Codecov.
|
I believe this is down to only established flaky tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows is failing https://build.osrfoundation.org/job/ign_gazebo-pr-win/4748/consoleFull#45593342ed30c675-ba23-4c35-b655-f5c948f97581
167 - INTEGRATION_reset_detachable_joint (Failed)
Signed-off-by: Michael Carroll <[email protected]>
I disabled the test to follow suit with the rest of the windows tests of this nature. |
🦟 Bug fix
Summary
This test exercises resetting a world with a detachable joint.
The simulation starts with an arm (simple_arm) and an object to be manipulated(object).
When simulation runs:
If physics and reset are implemented correctly, when the position of the arm is reset to x=-0.06, the block should not follow or stay attached via the detachable joint.
If physics and reset are implemented incorrectly, the block will move with the arm and fail the test.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.