Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case for simulation reset with detachable joints #1511

Merged
merged 7 commits into from
Jul 21, 2022
Merged

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented May 31, 2022

🦟 Bug fix

Summary

This test exercises resetting a world with a detachable joint.

The simulation starts with an arm (simple_arm) and an object to be manipulated(object).
When simulation runs:

  • At t=1.0, the arm is aligned with the object (x=+0.15),
  • At t=1.1, the arm forms the detchable joint
  • At t=3.0, the arm moves over the end of the table (x=+0.3)
  • At t=5.0, the simulation is reset

If physics and reset are implemented correctly, when the position of the arm is reset to x=-0.06, the block should not follow or stay attached via the detachable joint.
If physics and reset are implemented incorrectly, the block will move with the arm and fail the test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mjcarroll mjcarroll requested a review from chapulina as a code owner May 31, 2022 18:03
@chapulina chapulina added the 🌱 garden Ignition Garden label May 31, 2022
@mjcarroll mjcarroll changed the title Reset detachable Test case for simulation reset with detachable joints May 31, 2022
@mjcarroll mjcarroll marked this pull request as draft May 31, 2022 20:58
Base automatically changed from reset_sensors to main June 30, 2022 04:32
@mjcarroll mjcarroll marked this pull request as ready for review July 15, 2022 17:19
@mjcarroll mjcarroll requested a review from azeey as a code owner July 15, 2022 17:19
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1511 (0a70877) into main (a3cbd8c) will increase coverage by 0.01%.
The diff coverage is 99.31%.

❗ Current head 0a70877 differs from pull request most recent head 0793720. Consider uploading reports for the commit 0793720 to get more accurate results

@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
+ Coverage   63.62%   63.64%   +0.01%     
==========================================
  Files         330      330              
  Lines       25787    25925     +138     
==========================================
+ Hits        16408    16500      +92     
- Misses       9379     9425      +46     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17bae14...0793720. Read the comment docs.

@mjcarroll
Copy link
Contributor Author

I believe this is down to only established flaky tests.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

Windows is failing

I disabled the test to follow suit with the rest of the windows tests of this nature.

@chapulina chapulina added the tests Broken or missing tests / testing infra label Jul 19, 2022
@mjcarroll mjcarroll merged commit d43e437 into main Jul 21, 2022
@mjcarroll mjcarroll deleted the reset_detachable branch July 21, 2022 20:15
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants