Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Environment Variable Migration : gz-sim #1518

Merged
merged 6 commits into from
Jun 9, 2022
Merged

ign -> gz Environment Variable Migration : gz-sim #1518

merged 6 commits into from
Jun 9, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 4, 2022
Closed
49 tasks
@methylDragon methylDragon force-pushed the env_var_migration branch 2 times, most recently from 8a1ead5 to f7b1d39 Compare June 4, 2022 01:53
@chapulina chapulina added 🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. labels Jun 6, 2022
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bad comment from before, can you fix it here?

./src/ServerPrivate.hh:125:      /// Fuel will be checked and then the GZ_GAZEBO_RESOURCE_PATH environment

src/SystemLoader.cc Outdated Show resolved Hide resolved
src/cmd/cmdgazebo.rb.in Outdated Show resolved Hide resolved
src/cmd/cmdgazebo.rb.in Show resolved Hide resolved
src/network/PeerTracker_TEST.cc Outdated Show resolved Hide resolved
test/integration/log_system.cc Outdated Show resolved Hide resolved
src/Server_TEST.cc Show resolved Hide resolved
include/gz/sim/Util.hh Show resolved Hide resolved
include/gz/sim/Util.hh Show resolved Hide resolved
@methylDragon methylDragon requested a review from iche033 as a code owner June 7, 2022 19:18
@methylDragon
Copy link
Contributor Author

I found a bad comment from before, can you fix it here?

./src/ServerPrivate.hh:125:      /// Fuel will be checked and then the GZ_GAZEBO_RESOURCE_PATH environment

15e1119 !

@chapulina
Copy link
Contributor

Some of the test failures are new, compare to the failures on main:

https://build.osrfoundation.org/job/ignition_gazebo-ci-main-focal-amd64/33/#showFailuresLink

@methylDragon
Ticktock environment variables
ce803c9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Revert fuel cache path changes
815dec5 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix ticktocks
7195377 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Ticktock kXXXPathEnv env variables
c27d592 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix bad comment
1b063ba 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix broken namespace reference for env()
c4b6c42 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

Some of the test failures are new, compare to the failures on main:

build.osrfoundation.org/job/ignition_gazebo-ci-main-focal-amd64/33/#showFailuresLink

I ran this again locally, and that test passed 😰
I'm just waiting for CI to rerun the test..
image

@methylDragon
Copy link
Contributor Author

A new flaky test perhaps?

https://build.osrfoundation.org/job/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/8855/testReport/

chapulina
chapulina approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new flaky test perhaps?

huh could be, I think it may have needed one of the upstream libs' nightlies 🤔 Well, it's all good now!

@chapulina chapulina merged commit cbfae29 into main Jun 9, 2022
@chapulina chapulina deleted the env_var_migration branch June 9, 2022 02:28
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina