-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose rendering teardown event #1539
Expose rendering teardown event #1539
Conversation
64a147e
to
2bc0931
Compare
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 63.62% 63.60% -0.03%
==========================================
Files 330 330
Lines 25787 25847 +60
==========================================
+ Hits 16408 16439 +31
- Misses 9379 9408 +29
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michel Hidalgo <[email protected]>
2bc0931
to
35ffc53
Compare
@arjo129 small change to ensure custom rendering sensors that depend on builtin rendering sensors get destroyed first (not an issue right now, might become for someone else in the future). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor comment otherwise looks good to me.
Signed-off-by: Michel Hidalgo <[email protected]>
Agreed. Feel free to merge, CI is unstable for this branch right now, no need to block this PR. |
🎉 New feature
Follow-up after #1475. Turns out rendering sensor destruction must also occur in the rendering thread.
Summary
This patch adds a
rendering::RenderTeardown
event for downstream users to perform cleanup upon the rendering thread stopping.Test it
...
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.