Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Joint APIs for Parent/Child name #1548

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Use new Joint APIs for Parent/Child name #1548

merged 2 commits into from
Jun 21, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Follow-up to gazebosim/sdformat#1053.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey
azeey requested changes Jun 21, 2022
View reviewed changes
src/EntityComponentManager_TEST.cc Outdated Show resolved Hide resolved
chapulina
chapulina approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is unstable right now, we should retrigger it soon

@scpeters
Copy link
Member Author

homebrew just has some typical test failures and no compiler warnings

@scpeters
Copy link
Member Author

Ubuntu has a few test failures but no deprecation warnings

@scpeters scpeters merged commit 136c840 into main Jun 21, 2022
@scpeters scpeters deleted the scpeters/rename_joint_apis branch June 21, 2022 21:22
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey azeey approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scpeters @azeey @ahcorde @chapulina