-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the ability to stop a server #1551
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1551 +/- ##
============================================
Coverage 64.00% 64.01%
============================================
Files 317 317
Lines 25632 25635 +3
============================================
+ Hits 16407 16410 +3
Misses 9225 9225
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when CI comes back happy
Signed-off-by: Nate Koenig [email protected]
🎉 New feature
Summary
Exposes
ServerPrivate::Stop
through a newServer::Stop
function. This is useful when using Gazebo as a library.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.