Fix to modelphotoshoot test #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco A. Gutierrez <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1570 +/- ##
===============================================
- Coverage 64.01% 63.50% -0.51%
===============================================
Files 317 317
Lines 25635 26229 +594
===============================================
+ Hits 16410 16657 +247
- Misses 9225 9572 +347
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jul 1, 2022
luca-della-vedova
approved these changes
Jul 5, 2022
There was a problem hiding this comment.
Thanks for the fix! Looks good but not sure what to do with CI 😅
This will make #1563 obsolete and I'll close it after this is merged
chapulina
reviewed
Jul 6, 2022
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez [email protected]
🦟 Bug fix
This PR fixes the test for Model Photo Shoot system. Apparently the image generation contains some differences in color for a few pixels that would make it fail when comparing the exact content of the two images data. For now it will compare that most of the pixels are the same.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.