Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🕐 Tock: Remove Fortress deprecations #1605

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 20, 2022

Summary

Remove functionality that's deprecated since Fortress.

The bulk of it is related to the 3D scene and the ECM.

You can try loading the deprecated world, which asks for GzScene3D, and verify that it loads MinimalScene and other plugins instead:

gz sim -v 2 deprecated_ignition.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from mabelzhang as a code owner July 20, 2022 21:13
@chapulina chapulina requested a review from ahcorde July 20, 2022 21:13
@chapulina chapulina added the 🌱 garden Ignition Garden label Jul 20, 2022
examples/worlds/tracked_vehicle_simple.sdf Outdated Show resolved Hide resolved
@chapulina chapulina added bug Something isn't working Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Jul 23, 2022
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@mjcarroll
Copy link
Contributor

Has a small lint issue.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina changed the base branch from main to gz-sim7 August 10, 2022 18:16
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (gz-sim7@3f57c77). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             gz-sim7    #1605   +/-   ##
==========================================
  Coverage           ?   63.49%           
==========================================
  Files              ?      331           
  Lines              ?    26096           
  Branches           ?        0           
==========================================
  Hits               ?    16570           
  Misses             ?     9526           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina merged commit bfbe868 into gz-sim7 Aug 12, 2022
@chapulina chapulina deleted the chapulina/7/depre branch August 12, 2022 16:19
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. bug Something isn't working 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants