-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set seed value using CLI #1618
Set seed value using CLI #1618
Conversation
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, just pending a test
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Removed the This PR can either be merged into |
Signed-off-by: Aditya <[email protected]>
The CI failures here seem unrelated to the changes made here. |
* expose --seed to CLI Signed-off-by: Aditya <[email protected]>
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #1467
Summary
This PR exposes a
--seed
argument togz sim
to set seed value for the random number generator.Test it
Added a small test case that runs
gz sim -s -v 4 --seed 5 --iterations 5
and checks for the output string "Setting seed value: 5" in stdout.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸