Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow re-attaching detached joint #1687

Merged
merged 27 commits into from
Jun 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0d836d5
added re-attching feature on the detachable_joint plugin
liamhan0905 Sep 3, 2022
9471669
fixing white space issue provided by codecheck
liamhan0905 Sep 3, 2022
2a566bf
relaxing the tolerance
liamhan0905 Sep 3, 2022
1f7c238
adding igndbg msg for easier debugging for potential reattach flaky test
liamhan0905 Sep 3, 2022
5245a84
adding output publisher to be able to monitor the state of the detach…
liamhan0905 Sep 6, 2022
4320488
adding output publisher to be able to monitor the state of the detach…
liamhan0905 Sep 6, 2022
85c6307
Merge branch 'liam/add-attachable' of github.com:gazebosim/gz-sim int…
liamhan0905 Sep 11, 2022
74ae975
Merge branch 'ign-gazebo6' into liam/add-attachable
liamhan0905 Sep 11, 2022
02e11c5
fixing codecheck
liamhan0905 Sep 12, 2022
aac08c9
fixing multiple output topics to have unique child model name
liamhan0905 Sep 26, 2022
b6ccd69
fixing multiple detach topics to have unique child model name
liamhan0905 Sep 26, 2022
580b719
reverted back the change. changed the README to reflect that multiple…
liamhan0905 Sep 26, 2022
e11b100
added a gate to not invoke attach/detach if it's alreadyed attached/d…
liamhan0905 Sep 28, 2022
189847b
fixed test error
liamhan0905 Sep 28, 2022
fb4b5b6
changed the output topic variable name and added more comments on the…
liamhan0905 Oct 4, 2022
bf3c716
taking triggered_publisher.sdf file from this current PR
liamhan0905 Oct 4, 2022
80ada95
modifying examples to use detach_topic tag intead and changing igniti…
liamhan0905 Oct 10, 2022
66a2abe
add: handle backwards compatibility using <topic> tag instead of the …
liamhan0905 Nov 17, 2022
4154296
addressing PR review
liamhan0905 Apr 22, 2023
ef7fafa
addressing codecheck error
liamhan0905 Apr 25, 2023
79776c6
addressing PR review
liamhan0905 May 22, 2023
a002acb
modified the ignwarn -> igndbg since using topic tag shouldn't throw …
liamhan0905 May 22, 2023
da051bc
removed the '/'for compatibility issue
liamhan0905 May 22, 2023
31e3fe7
reverting back the '/'
liamhan0905 May 22, 2023
2ff8f52
adding more comments for the tutorials for clarification
liamhan0905 May 24, 2023
c7d0007
Merge remote-tracking branch 'origin/ign-gazebo6' into liam/add-attac…
azeey May 24, 2023
5bf2a93
Merge branch 'ign-gazebo6' into liam/add-attachable
liamhan0905 Jun 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modified the ignwarn -> igndbg since using topic tag shouldn't throw …
…any warnings in this version

Signed-off-by: Liam Han <[email protected]>
liamhan0905 committed May 22, 2023
commit a002acb292ac395ee3b8e260a31b5955b9556701
2 changes: 1 addition & 1 deletion src/systems/detachable_joint/DetachableJoint.cc
Original file line number Diff line number Diff line change
@@ -117,7 +117,7 @@ void DetachableJoint::Configure(const Entity &_entity,
}
else
{
ignwarn << "Ignoring <topic> tag and using <detach_topic> tag."
igndbg << "Ignoring <topic> tag and using <detach_topic> tag."
<< std::endl;
}
}