Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final update of ignitionrobotics to gazebosim for citadel #1760

Merged

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Oct 13, 2022

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

This cleans up the last references to ignitionrobotics (except references to bitbucket migration).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from mjcarroll as a code owner October 13, 2022 12:27
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 13, 2022
@nkoenig nkoenig merged commit 8856c44 into ign-gazebo3 Oct 13, 2022
@nkoenig nkoenig deleted the nkoenig/final-ignitionrobotics-gazebosim-citadel branch October 13, 2022 17:14
nkoenig added a commit that referenced this pull request Nov 3, 2022
* 🎈 3.14.0~pre1 (#1650)

Signed-off-by: Louise Poubel <[email protected]>

* Remove redundant namespace references (#1635)

Signed-off-by: methylDragon <[email protected]>

* 🎈 3.14.0 (#1657)

Signed-off-by: Louise Poubel <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>

* readd namespaces for Q_ARGS (#1670)

* Remove actors from screen when they are supposed to (#1699)

# 🦟 Bug fix

Supercedes #1697.  Note: When forward porting we will have to update the hashmaps to erase the new hashmaps created.

Fixes #<NUMBER>

## Summary
Found that when actors are De-spawned the actor visuals are not destroyed. This commit addresses this bug by adding the missing remove logic in RenderUtils.

## Before
![bug](https://user-images.githubusercontent.com/542272/189558600-196d98c5-1dcf-4d6c-93d6-7493df38c0e4.gif)

## After
![no_bug](https://user-images.githubusercontent.com/542272/189558924-3f2e3c5d-68f3-4d80-aee4-3dc3ce6742a1.gif)

## Notes:
Theres a lot of hashmaps being populated in RenderUtils whenever a new actor is spawned. I hope I've caught them all. 
Also while I need these working in garden (as all the projects Im working on use garden), should I backport these changes?

Signed-off-by: Arjo Chakravarty <[email protected]>

* Update examples to use gazebosim.org

Signed-off-by: Nate Koenig <[email protected]>

* Citadel: Removed warnings (#1753)

Signed-off-by: ahcorde <[email protected]>

* Added collection name to About Dialog (#1756)

Signed-off-by: ahcorde <[email protected]>

* Convert ignitionrobotics to gazebosim in tests directory (#1757)

* Convert ignitionrobotics to gaazebosim in tests directory

Signed-off-by: Nate Koenig <[email protected]>

* fix gz-gazebo

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Convert ignitionrobotics to gazebosim in sources and includes (#1758)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Convert ignitionrobotics to gazebosim in tutorials (#1759)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* Final update of ignitionrobotics to gazebosim for citadel (#1760)

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>

* remove PlotIcon (#1658)

Signed-off-by: youhy <[email protected]>

Signed-off-by: youhy <[email protected]>

* Fix UNIT_ign_TEST

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: youhy <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: methylDragon <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]>
Co-authored-by: Arjo Chakravarty <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: AzulRadio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants