Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abi-checker: patch typo in Export.hh #1778

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Nov 3, 2022

🦟 Bug fix

Fixes problem with abi checking in gz-sim7 branch. Note that there are probably more problems in abichecking preventing it to work, but solve fixed in release-tools.

Summary

Small duplicate word in an include is making the abichecker to fail since the file does not exist.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #1778 (b3af36b) into gz-sim7 (a738dec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-sim7    #1778   +/-   ##
========================================
  Coverage    64.19%   64.19%           
========================================
  Files          336      336           
  Lines        26830    26830           
========================================
  Hits         17224    17224           
  Misses        9606     9606           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@j-rivero j-rivero merged commit c4cd2c0 into gz-sim7 Nov 3, 2022
@j-rivero j-rivero deleted the jrivero/fix_type_abichecker branch November 3, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants