Add checkbox in view angle plugin for toggling view control reference visual #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… visual Signed-off-by: Ian Chen <[email protected]>
9 tasks
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1788 +/- ##
===============================================
+ Coverage 64.61% 64.68% +0.06%
===============================================
Files 321 321
Lines 26290 26358 +68
===============================================
+ Hits 16988 17049 +61
- Misses 9302 9309 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Nov 10, 2022
jennuine
approved these changes
Nov 10, 2022
| @@ -60,6 +60,9 @@ namespace ignition::gazebo | |||
| /// \brief View Control service name | |||
| public: std::string viewControlService; | |||
|
|
|||
| /// \brief View Control service name | |||
There was a problem hiding this comment.
Suggested change
| /// \brief View Control service name | |
| /// \brief View Control reference visual service name |
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on gazebosim/gz-gui#500
Summary
Adds check box for toggling the view control reference visual added in gazebosim/gz-gui#500.
Test it
Enable the
View Angleplugin by going to the top right 3 dots menu and selectView AngleClick on the
Display View Control Reference Visualcheck box to enable / disable view control anchor visualization. Use mouse to move camera and see the effect. When disabled, the yellow ellipsoid should not be drawn in the 3d render window.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.