Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add odom_topic to diff drive #179

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Add odom_topic to diff drive #179

merged 3 commits into from
Jun 4, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 4, 2020

This adds a <odom_topic> element to the DiffDrive system so that a custom odometry topic can be used.

Signed-off-by: Nate Koenig [email protected]

Add odom_topic to diff drive
0445b2c 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from chapulina as a code owner June 4, 2020 18:15
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jun 4, 2020
Changelog
7eb2685 
Signed-off-by: Nate Koenig <[email protected]>
chapulina
chapulina approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only small suggestion I have would be to use this in a test. Thanks for the extra docs!

@acschang acschang mentioned this pull request Jun 4, 2020
Merged
@codecov
Copy link

codecov bot commented Jun 4, 2020 •
edited
Loading

Codecov Report

Merging #179 into ign-gazebo2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo2     #179   +/-   ##
============================================
  Coverage        62.35%   62.35%           
============================================
  Files              123      123           
  Lines             6101     6101           
============================================
  Hits              3804     3804           
  Misses            2297     2297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 064fe6c...676e993. Read the comment docs.

Added a test
676e993 
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig
Copy link
Contributor Author

nkoenig commented Jun 4, 2020

LGTM. The only small suggestion I have would be to use this in a test. Thanks for the extra docs!

Test added: 676e993

chapulina
chapulina reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good

test/integration/diff_drive_system.cc Show resolved Hide resolved
@chapulina chapulina merged commit cbc69e5 into ign-gazebo2 Jun 4, 2020
@chapulina chapulina deleted the diff_drive_odom_topic branch June 4, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @chapulina