Fix setting cast shadows property for visuals with shader param system

[iche033]

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Currently setting the <cast_shadows> property for visuals that uses the ShaderParam system does not have any effect. The visual will always cast shadows. This PR fixes the issue so that users can toggle shadows on/off for these visuals.

To test:

Download the the deformable_sphere_no_shadows.sdf world that consists of a sphere model with ShaderParam system and <cast_shadows> set to false. Launch it to verify that the visual does not not cast shadows on the ground plane:

ign gazebo -v 4 deformable_sphere_no_shadows.sdf

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #1856 (8454b64) into ign-gazebo6 (68008d2) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##           ign-gazebo6    #1856   +/-   ##
============================================
  Coverage        64.80%   64.80%           
============================================
  Files              322      322           
  Lines            26389    26392    +3     
============================================
+ Hits             17101    17103    +2     
- Misses            9288     9289    +1     

Impacted Files	Coverage Δ
...rc/systems/ackermann_steering/AckermannSteering.cc	85.50% <71.42%> (-0.17%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.