Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: 6 to 7 (10-JAN-2023) #1857

Merged
merged 11 commits into from
Jan 13, 2023
Merged

port: 6 to 7 (10-JAN-2023) #1857

merged 11 commits into from
Jan 13, 2023

Conversation

mjcarroll
Copy link
Contributor

➡️ Forward port

Port ign-gazebo6 to gz-sim7

Branch comparison: gz-sim7...ign-gazebo6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 9 commits December 7, 2022 11:39
…ivity (#1799)

Closes #1027

Adds spin box that lets users sets the view controller sensitivity. The limits of the spin box are: [0.01, 10.0] with a step size of 0.1.

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
The dartsim component of gz-physics is currently not built on CI, so
these tests should be disabled.

Signed-off-by: Addisu Z. Taddese <[email protected]>
This adds the ISystemConfigureParameters interface, which
allows systems to declare parameters. This uses a
transport::parameters::ParametersRegistry and creates
services for listing, getting, and setting parameters.

Based on gazebosim/gz-transport#305.

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>

Signed-off-by: Marco A. Gutierrez <[email protected]>
Fix for handling Ackermann wheel steering angle bug where wheel always
points same direction when linVel is zero and abs(angVel) > 0.001.

Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
@mjcarroll mjcarroll requested a review from mabelzhang as a code owner January 10, 2023 17:28
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1857 (3dc8c7a) into gz-sim7 (f49fb5a) will increase coverage by 0.02%.
The diff coverage is 81.37%.

@@             Coverage Diff             @@
##           gz-sim7    #1857      +/-   ##
===========================================
+ Coverage    64.66%   64.68%   +0.02%     
===========================================
  Files          342      343       +1     
  Lines        27350    27430      +80     
===========================================
+ Hits         17685    17743      +58     
- Misses        9665     9687      +22     
Impacted Files Coverage Δ
include/gz/sim/System.hh 100.00% <ø> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
src/systems/thruster/Thruster.cc 86.20% <67.56%> (-3.70%) ⬇️
...rc/systems/ackermann_steering/AckermannSteering.cc 85.54% <71.42%> (-0.17%) ⬇️
src/SimulationRunner.cc 91.20% <80.00%> (-1.07%) ⬇️
src/SystemManager.cc 93.75% <84.61%> (-0.83%) ⬇️
src/systems/battery_plugin/LinearBatteryPlugin.cc 75.68% <94.59%> (+2.47%) ⬆️
include/gz/sim/components/BatteryPowerLoad.hh 100.00% <100.00%> (ø)
src/SystemInternal.hh 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

the homebrew CmdLine.* test failures are happening in other builds too so may not be related to this PR.

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

@mjcarroll
Copy link
Contributor Author

@osrf-jenkins retest this please

(I think this went through during the ubuntu mirrors going haywire)

@mjcarroll mjcarroll merged commit 1eb3a95 into gz-sim7 Jan 13, 2023
@mjcarroll mjcarroll deleted the ports/6_to_7 branch January 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants