Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignition alias back #1858

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Add ignition alias back #1858

merged 1 commit into from
Jan 12, 2023

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Jan 12, 2023

🦟 Bug fix

Fixes #

Summary

Till we fully move over to gzsim 8 we are supposed to retain an alias to ignition so users have time to migrate their codebase. Our plugin happily eliminated this option.

Signed-off-by: Arjo Chakravarty [email protected]

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Till we fully move over to gzsim 8 we are supposed to retain an alias to ignition so users have time to migrate their codebase. Our plugin happily eliminated this option.

Signed-off-by: Arjo Chakravarty <[email protected]>
@arjo129 arjo129 requested a review from mjcarroll as a code owner January 12, 2023 01:00
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1858 (6448858) into gz-sim7 (64c01fd) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           gz-sim7    #1858      +/-   ##
===========================================
+ Coverage    64.52%   64.64%   +0.12%     
===========================================
  Files          341      342       +1     
  Lines        27185    27350     +165     
===========================================
+ Hits         17540    17680     +140     
- Misses        9645     9670      +25     
Impacted Files Coverage Δ
src/systems/thruster/Thruster.cc 89.89% <100.00%> (ø)
src/systems/hydrodynamics/Hydrodynamics.cc 84.82% <0.00%> (-3.42%) ⬇️
...tems/environmental_sensor_system/TransformTypes.hh 100.00% <0.00%> (ø)
src/Util.cc 92.53% <0.00%> (+0.29%) ⬆️
...nmental_sensor_system/EnvironmentalSensorSystem.cc 84.04% <0.00%> (+1.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arjo129 arjo129 merged commit 561485e into gz-sim7 Jan 12, 2023
@arjo129 arjo129 deleted the arjo/fix/thruster branch January 12, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants