Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orientation to Odom with covariance. #1876

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

bperseghetti
Copy link
Member

@bperseghetti bperseghetti commented Jan 30, 2023

🦟 Bug fix

Fixes #1875

Summary

Adds orientation to Odometry plugin with covariance.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #1876 (c7ab427) into gz-sim7 (af73ebe) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head c7ab427 differs from pull request most recent head c263ef6. Consider uploading reports for the commit c263ef6 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1876      +/-   ##
===========================================
+ Coverage    64.64%   64.69%   +0.04%     
===========================================
  Files          343      343              
  Lines        27542    27544       +2     
===========================================
+ Hits         17805    17819      +14     
+ Misses        9737     9725      -12     
Impacted Files Coverage Δ
...rc/systems/odometry_publisher/OdometryPublisher.cc 87.98% <100.00%> (+0.10%) ⬆️
src/SimulationRunner.cc 92.15% <0.00%> (+1.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Also added test to avoid regression.

Signed-off-by: Benjamin Perseghetti <[email protected]>

Co-authored-by: James Goppert <[email protected]>
@bperseghetti bperseghetti force-pushed the pr-fix-odometry-orientation branch from 53ed579 to c263ef6 Compare January 30, 2023 21:38
@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bperseghetti
Copy link
Member Author

Yep, glad to get the fix in.

@mjcarroll mjcarroll merged commit d506dbd into gazebosim:gz-sim7 Feb 1, 2023
@bperseghetti bperseghetti deleted the pr-fix-odometry-orientation branch October 18, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Odometry plugin with covariance not publishing orientation.
2 participants