Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gz plugin paths in windows #1899

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Fix gz plugin paths in windows #1899

merged 1 commit into from
Feb 16, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 16, 2023

🦟 Bug fix

Summary

Replaced IGNITION_GAZEBO_PLUGIN_PATH with GZ_SIM_PLUGIN_PATH for windows for creating unversioned libraries.

I noticed that the IGNITION_GAZEBO_PLUGIN_PATH was completely removed in garden without being deprecated so I added it in config.hh

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner February 16, 2023 00:02
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1899 (90e63c4) into gz-sim7 (4380ab1) will increase coverage by 0.01%.
The diff coverage is 57.14%.

@@             Coverage Diff             @@
##           gz-sim7    #1899      +/-   ##
===========================================
+ Coverage    64.56%   64.58%   +0.01%     
===========================================
  Files          344      344              
  Lines        27578    27590      +12     
===========================================
+ Hits         17807    17818      +11     
- Misses        9771     9772       +1     
Impacted Files Coverage Δ
...int_position_controller/JointPositionController.cc 74.13% <57.14%> (+0.68%) ⬆️
src/systems/physics/Physics.cc 66.34% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iche033
Copy link
Contributor Author

iche033 commented Feb 16, 2023

The Failed to load system plugin error messages are now gone in the full console log in windows build:(https://build.osrfoundation.org/job/ign_gazebo-pr-win/5500/consoleFull.
As an example, the error messages were present in: https://build.osrfoundation.org/job/ign_gazebo-pr-win/5494/consoleFull

@iche033 iche033 merged commit 472ce16 into gz-sim7 Feb 16, 2023
@iche033 iche033 deleted the fix_plugin_path branch February 16, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants