Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sensor class #1912

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Add Sensor class #1912

merged 2 commits into from
Mar 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 2, 2023

🎉 New feature

Part of #325

Summary

Add generic Sensor class. Currently there are only a small set of API functions due to limited number of sensor components available.

In order to have APIs for doing things like setting update rate or active state, etc, we'll need to create new components and make use of them in all the relevant systems (e.g. imu, altimeter, sensors system, etc).

I also added one more API (ParentModel) to the Joint class that I missed in #1910.

Test it

Run the UNIT_Sensor_TEST and INTEGRATION_sensor tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from mjcarroll as a code owner March 2, 2023 22:12
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 2, 2023
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1912 (633d1bd) into ign-gazebo6 (89df3b7) will increase coverage by 0.00%.
The diff coverage is 87.87%.

❗ Current head 633d1bd differs from pull request most recent head 4610842. Consider uploading reports for the commit 4610842 to get more accurate results

@@             Coverage Diff              @@
##           ign-gazebo6    #1912   +/-   ##
============================================
  Coverage        64.99%   65.00%           
============================================
  Files              324      325    +1     
  Lines            26562    26595   +33     
============================================
+ Hits             17264    17287   +23     
- Misses            9298     9308   +10     
Impacted Files Coverage Δ
src/Sensor.cc 85.71% <85.71%> (ø)
src/Joint.cc 97.10% <100.00%> (+0.10%) ⬆️
src/SimulationRunner.cc 90.82% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde
Copy link
Contributor

ahcorde commented Mar 3, 2023

@osrf-jenkins run tests please!

@iche033 iche033 merged commit bd55d53 into ign-gazebo6 Mar 6, 2023
@iche033 iche033 deleted the sensor_api branch March 6, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants