-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gz_TEST: improve initial sim time test reliability #1916
Conversation
Add some sleep statements and increase test iterations. Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1916 +/- ##
===========================================
+ Coverage 64.54% 64.61% +0.06%
===========================================
Files 347 348 +1
Lines 27777 27853 +76
===========================================
+ Hits 17930 17997 +67
- Misses 9847 9856 +9
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
still flaky; it failed in one of the jammy actions: |
@@ -135,7 +135,7 @@ TEST(CmdLine, GazeboServer) | |||
TEST(CmdLine, SimtimeArgument) | |||
{ | |||
std::string cmd = | |||
kGzCommand + " -r -v 4 --iterations 100 --initial-sim-time 1000.5 " + | |||
kGzCommand + " -r -v 4 --iterations 500 --initial-sim-time 1000.5 " + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the loaded sdf file has some plugins, none of the more time consuming plugins such as Physics are loaded. Also, the plugins.sdf
world is set to run as fast as possible, so this command may finish running before transport is done initializing. My suggestion is to slow it down using -z 1000
or even -z 100
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Addisu Z. Taddese <[email protected]>
The ABI failure is because there are new changes in |
🦟 Bug fix
Improves reliability of a test added in #1801.
Summary
The test added in #1801 is a little flaky:
I've added delays, which wasn't enough on its own. For some reason the test subscriber on macOS doesn't get any messages for the first 100 iterations or so. Increasing to 200 iterations was enough in most cases on my machine, so I increased to 500 just to be safe. To reproduce the issue, reduce the iterations to 100 and view the console output.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.