Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on migrating the Joint class from gazebo classic #1925

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 10, 2023

🎉 New feature

Related to #325

Summary

Add migration tutorial for Gazebo classic's joint class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 10, 2023 23:48
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #1925 (239b4e4) into ign-gazebo6 (6437bb0) will decrease coverage by 12.69%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ign-gazebo6    #1925       +/-   ##
================================================
- Coverage        78.00%   65.31%   -12.69%     
================================================
  Files              255      327       +72     
  Lines            15041    26878    +11837     
================================================
+ Hits             11732    17555     +5823     
- Misses            3309     9323     +6014     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/EventManager.hh 79.16% <ø> (+0.90%) ⬆️
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/SystemLoader.hh 100.00% <ø> (ø)
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
... and 73 more

... and 116 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -0,0 +1,192 @@
\page migrationjointapi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dis you add this tutorial to an index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah just added in 87c7a2e

iche033 added 3 commits March 13, 2023 22:20
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@caguero caguero self-requested a review April 10, 2023 18:39
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict but other than that, all look good to me.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 dismissed ahcorde’s stale review April 20, 2023 17:29

resolved comment

@iche033
Copy link
Contributor Author

iche033 commented Apr 20, 2023

fixed conflict in 239b4e4

@iche033 iche033 merged commit 82f6851 into ign-gazebo6 Apr 20, 2023
@iche033 iche033 deleted the migration_joint branch April 20, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants