Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on migrating the Sensor class from gazebo classic #1930

Merged
merged 4 commits into from
May 1, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 14, 2023

🎉 New feature

Part of #325

Summary

Add migration tutorial for Gazebo classic's Sensor class.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner March 14, 2023 21:17
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1930 (1c8708a) into ign-gazebo6 (ef71b65) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1c8708a differs from pull request most recent head 56700c6. Consider uploading reports for the commit 56700c6 to get more accurate results

@@               Coverage Diff               @@
##           ign-gazebo6    #1930      +/-   ##
===============================================
- Coverage        65.31%   65.31%   -0.01%     
===============================================
  Files              327      327              
  Lines            26893    26878      -15     
===============================================
- Hits             17566    17556      -10     
+ Misses            9327     9322       -5     

see 5 files with indirect coverage changes

Signed-off-by: Ian Chen <[email protected]>
@azeey azeey requested a review from j-rivero March 20, 2023 18:32
iche033 added 2 commits March 27, 2023 22:12
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@mjcarroll mjcarroll merged commit 1a18071 into ign-gazebo6 May 1, 2023
@mjcarroll mjcarroll deleted the migration_sensor branch May 1, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants