Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize services in ViewAngle constructor #1943

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Mar 23, 2023

🦟 Bug fix

Summary

When loading the ViewAngle GUI plugin, the terminal shows the following message:

caguero@cold:~$ gz sim /home/caguero/garden_ws/install/share/gz/gz-sim7/worlds/minimal_scene.sdf
Service [] is not valid.

The reason for this is that we're trying to call Request() before the appropriate service name has been initialized. Before this patch, the services are initialized in LoadConfig(). We're now initializing the services in the constructor.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@caguero caguero requested a review from mjcarroll as a code owner March 23, 2023 22:50
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 23, 2023
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero merged commit fb45b59 into gz-sim7 Mar 24, 2023
@caguero caguero deleted the caguero/view_angle_init branch March 24, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants