Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GzSpinBox instead of IgnSpinBox in ViewAngle plugin #1969

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Apr 21, 2023

🦟 Bug fix

Summary

I'm getting this error in a downstream project (VRX) while trying to load the ViewAngle GUI plugin:

[GUI] [Err] [Plugin.cc:147] Failed to instantiate QML file [:/ViewAngle/ViewAngle.qml].
[ruby $(which gz) sim-1] * file::/ViewAngle/ViewAngle.qml:350:5: IgnSpinBox is not a type

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero requested a review from mjcarroll as a code owner April 21, 2023 18:01
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1969 (1d073e9) into gz-sim7 (f06d37a) will increase coverage by 0.02%.
The diff coverage is 73.52%.

❗ Current head 1d073e9 differs from pull request most recent head 675434e. Consider uploading reports for the commit 675434e to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1969      +/-   ##
===========================================
+ Coverage    65.04%   65.06%   +0.02%     
===========================================
  Files          352      352              
  Lines        28292    28318      +26     
===========================================
+ Hits         18402    18426      +24     
- Misses        9890     9892       +2     
Impacted Files Coverage Δ
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.cc 80.09% <73.52%> (-0.45%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 14d5832 into gz-sim7 Apr 27, 2023
@mjcarroll mjcarroll deleted the caguero/GzSpinBox branch April 27, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants